remove notes-to-self #3117
Open
remove notes-to-self #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3117 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 121 121
Lines 18155 18155
Branches 3270 3270
=======================================
Hits 18080 18080
Misses 52 52
Partials 23 23
|
|
does anybody have any opinions? @A5rocks @njsmith @Zac-HD @oremanj @graingert |
|
You could git commit them into the wiki https://github.com/python-trio/trio/wiki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think these are used by anybody in any way anymore? They mostly just seem to mess with linters/formatters and increase the size of the codebase by 200KB.
If we do want to keep them around for more visibility somewhere, and people actually expect to use and/or update them once in a blue mood, we could consider putting them in a separate repo in the python-trio org?
teamspen suggested making a tag. We could make a dedicated notes-to-self tag, but for now I just reused the
0.27.0tag.