Avoid refcycles in run exc #3120
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3120 +/- ##
==========================================
- Coverage 99.62% 99.44% -0.18%
==========================================
Files 122 122
Lines 18340 18346 +6
Branches 3281 3283 +2
==========================================
- Hits 18271 18245 -26
- Misses 47 78 +31
- Partials 22 23 +1
|
graingert
force-pushed
the
avoid-refcycles-in-run-exc
branch
from
0d79042
to
12e8395
Compare
A5rocks
reviewed
Oct 27, 2024
| @@ -1706,6 +1706,7 @@ def close(self) -> None: | |||
| self.asyncgens.close() | |||
| if "after_run" in self.instruments: | |||
| self.instruments.call("after_run") | |||
| self.system_nursery: Nursery | None = None | |||
There was a problem hiding this comment.
Type hint here isn't necessary
There was a problem hiding this comment.
As long as this isn't the first time system_nursery is set yes
There was a problem hiding this comment.
I think you accidentally left this instead of copying parts over as a test.
There was a problem hiding this comment.
Yep, sorry I pushed this in draft so I don't lose it
|
I'm currently trying to work out if this change makes it possible to test Line 2790 in 12e8395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.