Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using ctypes for traceback mutation #3203

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Feb 9, 2025

Fixes #405

It's kind of unnecessary since we'll rip this code out anyways once strict exception groups are the only thing supported, but for now it's simpler.

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00000%. Comparing base (8a7674c) to head (e3ed59d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3203   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             124          124           
  Lines           18792        18760   -32     
  Branches         1268         1267    -1     
===============================================
- Hits            18792        18760   -32     
Files with missing lines Coverage Δ
src/trio/_core/_concat_tb.py 100.00000% <100.00000%> (ø)

Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great other than a few comments that are now outdated

src/trio/_core/_concat_tb.py Outdated Show resolved Hide resolved
src/trio/_core/_concat_tb.py Outdated Show resolved Hide resolved
@A5rocks A5rocks requested a review from CoolCat467 February 10, 2025 04:40
Copy link
Member

@jakkdl jakkdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't really understand the magic going on, but if tests are passing then I assume it's fine

@A5rocks
Copy link
Contributor Author

A5rocks commented Feb 10, 2025

The pypy version is simpler to understand (at least imo) as a version to compare to.

... but yeah I'm hopeful that I didn't miss anything.

@A5rocks A5rocks added this pull request to the merge queue Feb 11, 2025
Merged via the queue into python-trio:main with commit c73c2ec Feb 11, 2025
39 checks passed
@A5rocks A5rocks deleted the remove-lines branch February 11, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use native traceback mutation on python 3.7
3 participants