Cleanup MacroElements #2088
Open
Cleanup MacroElements #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier I noted many macroelements do not fully use the facilities of Figure, but instead in render manipulate the parent Figure. Step 1: remove GlobalSwitches as Element
Step 2: cleanup Map. Remove unused code and imports Move style headers to the template All tests still pass.
Step 3: make Popups proper MacroElements
Check parameters during construction. This misses out on the assertion about needing Map as parent, but I doubt this will be a real issue anywhere.
Fixed the Draw plugin. Unfortunately there is no automated test for the Draw plugin. Instead I tested using the example app from streamlit-folium.
raster_layers.py
Do heat_map_withtime.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During an earlier change, I noted that many
MacroElementsubclasses do not fully use the templating facilities of their parent class.This PR makes the code more internally consistent by using the template route where possible. I skipped the
DualMap,VegaandVegaliteclasses because I do not fully understand what is happening there.