Skip to content

Commit

Permalink
version_sort_key -> compute_version_sort_key
Browse files Browse the repository at this point in the history
  • Loading branch information
Jackenmen committed Oct 16, 2024
1 parent ea206e0 commit 4871671
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cherry_picker/cherry_picker.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def upstream(self):
def sorted_branches(self):
"""Return the branches to cherry-pick to, sorted by version."""
return sorted(
self.branches, key=functools.partial(version_sort_key, self.config)
self.branches, key=functools.partial(compute_version_sort_key, self.config)
)

@property
Expand Down Expand Up @@ -829,7 +829,7 @@ def get_base_branch(cherry_pick_branch, *, config):

# Subject the parsed base_branch to the same tests as when we generated it
# This throws a ValueError if the base_branch doesn't meet our requirements
version_sort_key(config, base_branch)
compute_version_sort_key(config, base_branch)

return base_branch

Expand All @@ -849,7 +849,7 @@ def validate_sha(sha):
)


def version_sort_key(config, branch):
def compute_version_sort_key(config, branch):
"""
Get sort key based on version information from the given git branch name.
Expand Down

0 comments on commit 4871671

Please sign in to comment.