Allow specifying custom upstream remote name #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed the conflicts. |
DanielNoord
suggested changes
Jul 8, 2022
| cp = CherryPicker( | ||
| "origin", | ||
| "22a594a0047d7706537ff2ac676cdc0f1dcb329c", | ||
| branches, |
There was a problem hiding this comment.
Suggested change
| branches, | |
| ["3.6"], |
There was a problem hiding this comment.
| if remote_name != "origin": | ||
| git_remote("add", "origin", "https://github.com/miss-islington/cpython.git") | ||
|
|
||
| branches = ["3.6"] |
There was a problem hiding this comment.
Suggested change
| branches = ["3.6"] |
Why assign to a variable if you can just pass it directly?
There was a problem hiding this comment.
Because it's consistent with the rest of the code in this file. Or more truthfully... Because I copy-pasted one of the other test cases when making this one :) I'm indifferent to what's done here but I'll wait to change it until one of the maintainers requests it.
5 tasks
Co-authored-by: Ezio Melotti <[email protected]>
Mariatta
approved these changes
Oct 3, 2022
|
Thanks for the PR, sorry it's taking so long to look into it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19