Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build via 'python -m build' #92

Closed
wants to merge 1 commit into from
Closed

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 11, 2023

This should fix #91.

python -m build .
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (flit_core>=3.2,<4)
* Getting build dependencies for sdist...
* Building sdist...
* Building wheel from sdist
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (flit_core>=3.2,<4)
* Getting build dependencies for wheel...
* Building wheel...
Successfully built cherry_picker-2.2.0.tar.gz and cherry_picker-2.2.0-py3-none-any.whlls dist
cherry_picker-2.2.0-py3-none-any.whl cherry_picker-2.2.0.tar.gz

@Mariatta
Copy link
Member

Can we use flit publish?

@hugovk
Copy link
Member Author

hugovk commented Oct 11, 2023

I've never used flit as a command, but the docs say of flit publish:

Build a wheel and an sdist (tarball) from the package, and upload them to PyPI or another repository.

https://flit.pypa.io/en/stable/cmdline.html#flit-publish

So it could potentially replace both of these lines (and update the pip install):

          python -m build .
          twine upload dist/*

But I'll look into trusted publishers as a longer term fix.

@Mariatta
Copy link
Member

I think let's just get this set up with Trusted Publishers and the GItHub Actions that you mentioned.

@hugovk
Copy link
Member Author

hugovk commented Oct 16, 2023

Superseded by Trusted Publishing 🚀

#94

@hugovk hugovk closed this Oct 16, 2023
@hugovk hugovk deleted the python-m-build branch October 16, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Releasing using twine is broken
2 participants