-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-109190: What's New in 3.12: Add subheadings to removals for easy linking #109159
Merged
hugovk
merged 5 commits into
python:main
from
hugovk:doc-whatsnew-3.12-removed-subheadings
Sep 11, 2023
Merged
gh-109190: What's New in 3.12: Add subheadings to removals for easy linking #109159
hugovk
merged 5 commits into
python:main
from
hugovk:doc-whatsnew-3.12-removed-subheadings
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
A
Co-authored-by: Adam Turner <[email protected]>
AA-Turner
changed the title
What's New in 3.12: Add subheadings to removals for easy linking
gh-109190: What's New in 3.12: Add subheadings to removals for easy linking
Sep 9, 2023
AA-Turner
approved these changes
Sep 10, 2023
Co-authored-by: Adam Turner <[email protected]>
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2023
…easy linking (pythonGH-109159) (cherry picked from commit 57b6205) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Adam Turner <[email protected]>
GH-109273 is a backport of this pull request to the 3.12 branch. |
Yhg1s
pushed a commit
that referenced
this pull request
Sep 12, 2023
… easy linking (GH-109159) (#109273) gh-109190: What's New in 3.12: Add subheadings to removals for easy linking (GH-109159) (cherry picked from commit 57b6205) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Adam Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add subheadings to the Removed section.
Similar to Improved Modules, this gives us hyperlink anchors for the subheadings and makes it easy to share direct links. For example, I wanted to share a direct link to the
ssl.match_hostname()
removal, but had to use https://docs.python.org/3.12/whatsnew/3.12.html#removed which is a bit further away.Before: https://docs.python.org/3.12/whatsnew/3.12.html#removed
After: https://cpython-previews--109159.org.readthedocs.build/en/109159/whatsnew/3.12.html#removed
📚 Documentation preview 📚: https://cpython-previews--109159.org.readthedocs.build/en/109159/whatsnew/3.12.html#removed