ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner #109737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As we're editing this, the last two names were tacked on the end, instead of being in "rough alphabetical order by last names". (But not the name beginning Å, that comes after Z.) Would you like to slot them back into place? |
|
Doroschenko is already present in the right order, it seems! I also took the liberty of adding myself, if that's alright? A |
AA-Turner
changed the title
hugovk
approved these changes
Sep 22, 2023
AA-Turner
added
needs backport to 3.11
carljm
approved these changes
Sep 22, 2023
ambv
reviewed
Sep 22, 2023
|
Thanks @AA-Turner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 22, 2023
…ythonGH-109737) (cherry picked from commit 3e8fcb7) Co-authored-by: Adam Turner <[email protected]>
|
GH-109741 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 22, 2023
…ythonGH-109737) (cherry picked from commit 3e8fcb7) Co-authored-by: Adam Turner <[email protected]>
|
GH-109742 is a backport of this pull request to the 3.11 branch. |
AlexWaygood
pushed a commit
that referenced
this pull request
Sep 22, 2023
…rner (GH-109737) (#109742) ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner (GH-109737) (cherry picked from commit 3e8fcb7) Co-authored-by: Adam Turner <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Sep 22, 2023
…rner (GH-109737) (#109741) (cherry picked from commit 3e8fcb7) Co-authored-by: Adam Turner <[email protected]>
csm10495
pushed a commit
to csm10495/cpython
that referenced
this pull request
Sep 28, 2023
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @itamaro
Following on from #109661, hope you don't mind me opening the PR!
A