-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-119336: Restore _PyLong_NumBits #119418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not convinced that we have to revert this function: #119336 (comment) |
vstinner
reviewed
May 29, 2024
Misc/NEWS.d/next/C API/2024-05-22-17-50-48.gh-issue-119336.ff3qnS.rst
Outdated
Show resolved
Hide resolved
vstinner
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 3, 2024
…-119418) It is used by the pywin32 project. (cherry picked from commit e50fac9) Co-authored-by: Ethan Smith <[email protected]>
GH-119970 is a backport of this pull request to the 3.13 branch. |
vstinner
pushed a commit
that referenced
this pull request
Jun 3, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…19418) It is used by the pywin32 project.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…19418) It is used by the pywin32 project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used in pywin32, and the function being moved to internal headers broke with 3.13. Restore it for now to eventually be considered for being made a public symbol.
See also #112026 (previous restoration) and #111481 (public replacements)
This should be backported to 3.13 if accepted.