Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119336: Restore _PyLong_NumBits #119418

Merged
merged 4 commits into from
May 30, 2024

Conversation

emmatyping
Copy link
Contributor

@emmatyping emmatyping commented May 22, 2024

This is used in pywin32, and the function being moved to internal headers broke with 3.13. Restore it for now to eventually be considered for being made a public symbol.

See also #112026 (previous restoration) and #111481 (public replacements)

This should be backported to 3.13 if accepted.

@encukou encukou requested a review from vstinner May 28, 2024 14:30
@vstinner
Copy link
Member

I'm not convinced that we have to revert this function: #119336 (comment)

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner enabled auto-merge (squash) May 29, 2024 09:32
@vstinner vstinner merged commit e50fac9 into python:main May 30, 2024
38 checks passed
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Jun 3, 2024
@miss-islington-app
Copy link

Thanks @ethanhs for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2024
…-119418)

It is used by the pywin32 project.
(cherry picked from commit e50fac9)

Co-authored-by: Ethan Smith <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 3, 2024

GH-119970 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 3, 2024
vstinner pushed a commit that referenced this pull request Jun 3, 2024
…) (#119970)

gh-119336: Restore removed _PyLong_NumBits() function (GH-119418)

It is used by the pywin32 project.
(cherry picked from commit e50fac9)

Co-authored-by: Ethan Smith <[email protected]>
@emmatyping emmatyping deleted the replace_pylong_numbits branch June 11, 2024 20:34
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants