Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-125710: [Enum] fix hashable<->nonhashable comparisons for member values #125735

Merged
merged 2 commits into from
Oct 22, 2024
Merged

gh-125710: [Enum] fix hashable<->nonhashable comparisons for member values #125735

merged 2 commits into from
Oct 22, 2024

Conversation

ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Oct 19, 2024 •
edited by bedevere-app bot
Loading

@ethanfurman ethanfurman self-assigned this Oct 19, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 19, 2024
Closed
@ethanfurman ethanfurman added type-bug An unexpected behavior, bug, or error stdlib Python modules in the Lib dir 3.13 bugs and security fixes 3.14 new features, bugs and security fixes needs backport to 3.13 bugs and security fixes labels Oct 19, 2024
Eclips4
Eclips4 reviewed Oct 19, 2024
View reviewed changes
Lib/test/test_enum.py Outdated Show resolved Hide resolved
rruuaanng
rruuaanng reviewed Oct 20, 2024
View reviewed changes
Lib/enum.py Show resolved Hide resolved
Lib/enum.py Show resolved Hide resolved
Lib/enum.py Show resolved Hide resolved
Misc/NEWS.d/next/Library/2024-10-19-13-37-37.gh-issue-125710.FyFAAr.rst Show resolved Hide resolved
@ethanfurman ethanfurman merged commit aaed91c into python:main Oct 22, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@ethanfurman ethanfurman deleted the enum-non_hash branch October 22, 2024 18:04
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2024
@ethanfurman @miss-islington
pythongh-125710: [Enum] fix hashable<->nonhashable comparisons for me…
af8949e 
…mber values (pythonGH-125735)

(cherry picked from commit aaed91c)

Co-authored-by: Ethan Furman <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 22, 2024

GH-125851 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 22, 2024
ethanfurman added a commit that referenced this pull request Oct 22, 2024
@miss-islington @ethanfurman
[3.13] gh-125710: [Enum] fix hashable<->nonhashable comparisons for m…
5bb0538 
…ember values (GH-125735) (GH-125851)

gh-125710: [Enum] fix hashable<->nonhashable comparisons for member values (GH-125735)
(cherry picked from commit aaed91c)

Co-authored-by: Ethan Furman <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@ethanfurman @ebonnal
pythongh-125710: [Enum] fix hashable<->nonhashable comparisons for me…
c1a4d06 
…mber values (pythonGH-125735)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rruuaanng rruuaanng rruuaanng left review comments

@Eclips4 Eclips4 Eclips4 left review comments

Assignees

@ethanfurman ethanfurman

Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethanfurman @Eclips4 @rruuaanng