-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-127481: Add EPOLLWAKEUP
to the select
module
#127482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The EPOLL_URING_WAKE
is documented as being internal only. Similarly, EPOLLWAKEUP
has some constraints:
/*
* Request the handling of system wakeup events so as to prevent system suspends
* from happening while those events are being processed.
*
* Assuming neither EPOLLET nor EPOLLONESHOT is set, system suspends will not be
* re-allowed until epoll_wait is called again after consuming the wakeup
* event(s).
*
* Requires CAP_BLOCK_SUSPEND
*/
I'm not sure we should add EPOLL_URING_WAKE
. As for EPOLLWAKEUP
, I think a .. versionadded:: next
entry could be good (it also requires Linux Kernel 4.5 or later so such mention is worth adding).
Misc/NEWS.d/next/Library/2024-12-01-23-18-43.gh-issue-127481.K36AoP.rst
Outdated
Show resolved
Hide resolved
Yes, it's a restricted function, but it does not prevent us from providing it to users who turn it on. Edit
Good suggestion. I'll add the version number that appeared for the first time tomorrow. It's too late today. But for |
There is something just after the table... It says exactly what I expect the entry to say. |
Ehm... I saw it :(, I'll add it. |
CI failures look unrelated. I'll investigate. |
So, based on the 66 return code that looks like an actual data race. But, I wasn't able to find anything recent related to that test, so it must be exceptionally rare. Re-running jobs seemed to do the trick, someone @ me if you notice it on another PR. |
Thank you for your work. If there is any problem, I'll contact you as soon as problem :) |
EPOLL_URING_WAKE
, EPOLLWAKEUP
constants to select moduleEPOLLWAKEUP
constants to select module
EPOLLWAKEUP
constants to select moduleEPOLLWAKEUP
to the select
module
Misc/NEWS.d/next/Library/2024-12-01-23-18-43.gh-issue-127481.K36AoP.rst
Outdated
Show resolved
Hide resolved
Thank you! |
@encukou Thank you for your merge. |
EPOLLWAKEUP
to the select module #127481📚 Documentation preview 📚: https://cpython-previews--127482.org.readthedocs.build/