-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link to the correct output method in documentation #127857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The CPython 3.6 is already EOL. We usually backport documentation fixes only to current stable releases.
Thanks @kviktor for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
(cherry picked from commit 11ff328) Co-authored-by: Viktor Kálmán <[email protected]>
GH-127900 is a backport of this pull request to the 3.13 branch. |
(cherry picked from commit 11ff328) Co-authored-by: Viktor Kálmán <[email protected]>
GH-127901 is a backport of this pull request to the 3.12 branch. |
…#127900) link to the correct output method in documentation (GH-127857) (cherry picked from commit 11ff328) Co-authored-by: Viktor Kálmán <[email protected]>
…#127901) link to the correct output method in documentation (GH-127857) (cherry picked from commit 11ff328) Co-authored-by: Viktor Kálmán <[email protected]>
BaseCookie
also had anoutput
method so the link linked to that, instead ofMorsel
's output at https://docs.python.org/3/library/http.cookies.html#http.cookies.BaseCookie.outputIn theory this can be backported until 3.6 https://docs.python.org/3.6/library/http.cookies.html#http.cookies.BaseCookie.output but not sure if that is needed here.
📚 Documentation preview 📚: https://cpython-previews--127857.org.readthedocs.build/