Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to the correct output method in documentation #127857

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

kviktor
Copy link
Contributor

@kviktor kviktor commented Dec 12, 2024

BaseCookie also had an output method so the link linked to that, instead of Morsel's output at https://docs.python.org/3/library/http.cookies.html#http.cookies.BaseCookie.output

In theory this can be backported until 3.6 https://docs.python.org/3.6/library/http.cookies.html#http.cookies.BaseCookie.output but not sure if that is needed here.


📚 Documentation preview 📚: https://cpython-previews--127857.org.readthedocs.build/

Copy link

cpython-cla-bot bot commented Dec 12, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Dec 12, 2024
@skirpichev skirpichev added skip issue 3.12 bugs and security fixes 3.13 bugs and security fixes labels Dec 12, 2024
Copy link
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The CPython 3.6 is already EOL. We usually backport documentation fixes only to current stable releases.

@skirpichev skirpichev added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes and removed 3.12 bugs and security fixes 3.13 bugs and security fixes labels Dec 12, 2024
@kumaraditya303 kumaraditya303 merged commit 11ff328 into python:main Dec 13, 2024
50 checks passed
@miss-islington-app
Copy link

Thanks @kviktor for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 13, 2024
(cherry picked from commit 11ff328)

Co-authored-by: Viktor Kálmán <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 13, 2024

GH-127900 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 13, 2024
(cherry picked from commit 11ff328)

Co-authored-by: Viktor Kálmán <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 13, 2024

GH-127901 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 13, 2024
kumaraditya303 pushed a commit that referenced this pull request Dec 13, 2024
…#127900)

link to the correct output method in documentation (GH-127857)
(cherry picked from commit 11ff328)

Co-authored-by: Viktor Kálmán <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request Dec 13, 2024
…#127901)

link to the correct output method in documentation (GH-127857)
(cherry picked from commit 11ff328)

Co-authored-by: Viktor Kálmán <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants