-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-128039: Clarify the uninstallation instructions for Mac. #128040
base: main
Are you sure you want to change the base?
gh-128039: Clarify the uninstallation instructions for Mac. #128040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! My only suggestion is to include the free-threaded option in the list.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
* Also within the |usemac_applications_folder_name| folder: :program:`Python Launcher`, which handles double-clicking | ||
Python scripts from the macOS `Finder <https://support.apple.com/en-us/HT201732>`_; | ||
|
||
* A :file:`3.13` folder (under the "framework" :file:`/Library/Frameworks/Python.framework`), which includes the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than hardcoding 3.13
which is only correct for a single branch, let's use a "replacement":
* A :file:`3.13` folder (under the "framework" :file:`/Library/Frameworks/Python.framework`), which includes the | |
* A |usemac_x_dot_y_literal| folder (under the "framework" :file:`/Library/Frameworks/Python.framework`), which includes the |
And add it with the others in this file:
.. |usemac_x_dot_y| replace:: 3.13
+.. |usemac_x_dot_y_literal| replace:: ``3.13``
.. |usemac_python_x_dot_y_literal| replace:: ``python3.13``
.. |usemac_python_x_dot_y_t_literal| replace:: ``python3.13t``
.. |usemac_python_x_dot_y_t_literal_config| replace:: ``python3.13t-config``
And actually, those are still hardcoded, so let's remove the usemac_
prefix and integrate them into the rst_epilog
which uses the current version number:
Lines 77 to 80 in be8ae08
rst_epilog = f""" | |
.. |python_version_literal| replace:: ``Python {version}`` | |
.. |python_x_dot_y_literal| replace:: ``python{version}`` | |
.. |usr_local_bin_python_x_dot_y_literal| replace:: ``/usr/local/bin/python{version}`` |
The rst_epilog
replacements are available for all pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is surely The Right Thing®, but I'm unfamiliar enough with ReStructured Text to do it myself (I took a stab at it and found myself going in circles after an hour).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, we can do it in a followup. Thank you for trying!
I've applied the wording that I suggested in #128039 .
📚 Documentation preview 📚: https://cpython-previews--128040.org.readthedocs.build/