Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-127949: add docs for asyncio policy deprecation #128269

Merged
merged 6 commits into from
Dec 26, 2024

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Dec 26, 2024

@bedevere-app bedevere-app bot mentioned this pull request Dec 26, 2024
7 tasks
@bedevere-app bedevere-app bot added the docs Documentation in the Doc dir label Dec 26, 2024
@kumaraditya303 kumaraditya303 marked this pull request as ready for review December 26, 2024 09:50
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.14.rst Show resolved Hide resolved
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you want to add .. deprecated to every class and functions you mentioned, you can do it but since you deprecated the entire module in one go, I don't know if it's worth it or not. The only reason why I would suggest this is for users that do an online search and for IDEs that render Python docs based on the remote docs and that would miss the top-level warning.

@kumaraditya303
Copy link
Contributor Author

If you want to add .. deprecated to every class and functions you mentioned, you can do it but since you deprecated the entire module in one go, I don't know if it's worth it or not.

That was already done as part of individual PRs.

image

@picnixz
Copy link
Contributor

picnixz commented Dec 26, 2024

Perfect! (sorry since the diff didn't show it I wasn't aware of; I thought you waited for those changes actually or I didn't remember this). My approval remains then.

@kumaraditya303 kumaraditya303 merged commit 3eb746a into python:main Dec 26, 2024
29 checks passed
@kumaraditya303 kumaraditya303 deleted the docs branch December 26, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news topic-asyncio
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants