Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-131002: clarify how to enforce sqlite3 column types for generated fields #131006

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Mar 9, 2025

  • reorder PARSE_DECLTYPES and PARSE_COLNAMES doc entries so PARSE_DECLTYPES comes first, as its example introduces the example SQL table
  • clarify how to properly quote column names
  • help the reader to use converters for generated fields

📚 Documentation preview 📚: https://cpython-previews--131006.org.readthedocs.build/

@erlend-aasland
Copy link
Contributor Author

WDYT, @DLu and @picnixz?

@@ -472,6 +454,25 @@ Module constants
This flag may be combined with :const:`PARSE_COLNAMES` using the ``|``
(bitwise or) operator.

Generated fields (for example ``MAX(data)``) are returned as :class:`str`;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the semi-colon here. @AA-Turner, does this read slightly off-kilter?

Copy link

@DLu DLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants