-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-134004: Dbm vacuuming #134028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Andrea-Oliveri
wants to merge
12
commits into
python:main
Choose a base branch
from
Andrea-Oliveri:dbm-vacuum-gh134004
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
gh-134004: Dbm vacuuming #134028
+139
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
…ce to module links not found
…m.dumb for consistency with dbm.gnu. Also updated documentations and tests to reflect the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-134004:
.reorganize()
method todbm.sqlite
anddbm.dumb
which allows to retrieve unused space from database files. Name was chosen for consistency withdbm.gnu
.reorganize().
dbm.ndbm` does not support any such optimization.dbm.dumb.reorganize()
is a new custom implementation rewriting the database file in-place and removing the gaps left by deletions, then truncating the excess..reorganize()
runs as expected on all compatibledbm
submodules.dbm
module to include contributed methods as well as to highlight some of the limitations of the current implementations, such as lack of concurrency compatibility (fordbm.dumb
) and lack of automatic reorganizing.reorganize()
method toshelve
to expose dbm's submodules methodsshelve.reorganize()
Note: Unfortunately I did not feel comfortable changing the C code at this time, so I chose not to add an empty
.reorganize()
method todbm.ndbm
. This resulted in:dbm
submodules.hasattr()
, whether thedbm
objects have the.reorganize()
method and succeed early if that is not the case.