gh-101100: Fix references in http.cookiejar docs #114658 #136238
Conversation
bedevere-app
bot
added
awaiting review
docs
There was a problem hiding this comment.
Please keep it as is. The attributes documented after this "weird" paragraph are the flags. This paragraph serves as a separation between regulat attributes and class variable constants that behave like flags.
In the future, please first create an issue to discuss such changes before or carefully check that there is something to change.
Note: the backlink is an issue that can be solved by this PR but don't move around the docs. Just add the DefaultCookiePolicy namespace and the ~ to suppress the fully qualified name.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Use the issue that aims to remove warnings in the docs for this one. |
LamentXU123
changed the title
DefaultCookiePolicy.strict_ns_domain
|
Done. Thank you for your review.
|
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @picnixz: please review the changes made to this pull request. |
|
@ZeroIntensity Can you remove my old review and merge this one? TiA |
ZeroIntensity
added
awaiting merge
needs backport to 3.13
|
Thanks @LamentXU123 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @LamentXU123 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…6238) (cherry picked from commit f0c7344) Co-authored-by: Weilin Du <[email protected]>
…6238) (cherry picked from commit f0c7344) Co-authored-by: Weilin Du <[email protected]>
|
GH-136317 is a backport of this pull request to the 3.13 branch. |
|
GH-136318 is a backport of this pull request to the 3.14 branch. |
…GH-136318) gh-101100: Fix references in `http.cookiejar` docs (GH-136238) (cherry picked from commit f0c7344) Co-authored-by: Weilin Du <[email protected]>
…GH-136317) gh-101100: Fix references in `http.cookiejar` docs (GH-136238) (cherry picked from commit f0c7344) Co-authored-by: Weilin Du <[email protected]>
The origial doc is:
Since there is no highlights or any reference, I see no reason to split the doc of
strict_ns_domain. I think maybe we can make the description of the acceptable value just belowstrict_ns_domain? The two addtributes within are likely to be added in the wrong place.Another thing is the referrence link of
strict_ns_domainis invalid in the original doc, since it's been interrupted and can't locate the attribute. (The .rst file is here)This PR change it to:
Skipping issues and news ;)
📚 Documentation preview 📚: https://cpython-previews--136238.org.readthedocs.build/