gh-135552: Add tests that check if weakref for tp_subclasses cleared after finalization #136304
+76
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this PR should skip news |
neonene
reviewed
Jul 4, 2025
Comment on lines
+1201
to
+1202
| assert b"Instance weakref is not None" not in stderr | ||
| assert b"Type weakref is not Class" not in stderr |
There was a problem hiding this comment.
I do not know the issue, but the "not in" assertions look unreliable. The test will pass forever once the strings are accidentally changed. Also, any reason not to use self.assert*()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for #136189