gh-136306: Add support for SSL groups #136307
Open
+319
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial implementation of the feature proposed in issue python#136306.
3 tasks
picnixz
changed the title
picnixz
reviewed
Jul 5, 2025
| >>> ctx.get_groups() | ||
| ['secp256r1', 'secp384r1', 'secp521r1', 'x25519', 'x448', 'brainpoolP256r1tls13', 'brainpoolP384r1tls13', 'brainpoolP512r1tls13', 'ffdhe2048', 'ffdhe3072', 'ffdhe4096', 'ffdhe6144', 'ffdhe8192', 'MLKEM512', 'MLKEM768', 'MLKEM1024', 'SecP256r1MLKEM768', 'X25519MLKEM768', 'SecP384r1MLKEM1024' | ||
|
|
||
| .. versionadded:: 3.15 |
There was a problem hiding this comment.
Suggested change
| .. versionadded:: 3.15 | |
| .. versionadded:: next |
Comment on lines
+1648
to
+1650
| values. | ||
|
|
||
| Example:: |
There was a problem hiding this comment.
Suggested change
| values. | |
| Example:: | |
| values. For example:: |
And remove the indentation in the example (I don't think it's necessary)
| <https://docs.openssl.org/master/man3/SSL_CTX_set1_groups_list/>`_. | ||
|
|
||
| .. note:: | ||
| when connected, the :meth:`SSLSocket.group` method of SSL sockets will |
There was a problem hiding this comment.
Suggested change
| when connected, the :meth:`SSLSocket.group` method of SSL sockets will | |
| When connected, the :meth:`SSLSocket.group` method of SSL sockets will |
| @@ -1789,6 +1817,10 @@ to speed up repeated connections from the same clients. | |||
|
|
|||
| .. versionadded:: 3.3 | |||
|
|
|||
| .. deprecated:: 3.15 | |||
There was a problem hiding this comment.
This should be done in a separate PR as it would be better to raise a warning. Leave it supported for now.
| @@ -0,0 +1 @@ | |||
| :mod:`ssl` can now get and set groups used for key agreement. | |||
There was a problem hiding this comment.
We need a what's new entry as well.
| if (self->ssl == NULL) | ||
| Py_RETURN_NONE; | ||
| group_name = SSL_get0_group_name(self->ssl); | ||
| if (group_name == NULL) |
There was a problem hiding this comment.
Please follow PEP-7 for new code (add braces).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of the feature proposed in issue #136306.
📚 Documentation preview 📚: https://cpython-previews--136307.org.readthedocs.build/