-
-
Notifications
You must be signed in to change notification settings - Fork 33k
[3.14] gh-138171: Migrate iOS testbed location and add Apple build script (#138176) #139204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ipt (python#138176) Adds tooling to generate and test an iOS XCframework, in a way that will also facilitate adding other XCframework targets for other Apple platforms (tvOS, watchOS, visionOS and even macOS, potentially). --------- Co-authored-by: Hugo van Kemenade <[email protected]> (cherry picked from commit 35c7e52)
!buildbot iOS |
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 659cb85 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139204%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Tagging @hugovk following our discussion at PyCon UK, for consideration in 3.14.0 final. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the original binary stubs in iOS/Resources/bin remain in the repo after this PR; this is also the case in main. I assume the whole iOS directory should be removed. If so, suggest to do that in a separate PR for main and backport that to 3.14 after this PR is merged.
Otherwise LGTM. I successfully built and ran the testsuite using ./Apple with Xcode 26 on macOS 26.0 running on an Apple Silicon Mac and on macOS 15.6.1 running on an Intel Mac.
We will also need a tweak to the buildbots to allow for differentiating build instructions for PR builds based on branch; however, speaking with @ambv at the sprint last week, he indicated this is something that has been on the wishlist for a while. If we can fix that, then we can modify the buildbot to have a different instruction set for 3.14+ and 3.13 PRs, and then delete the iOS directory from both the 3.14 and main branches. |
Was closing this PR intended? A |
@AA-Turner Ooops - it was not. Collateral damage of some over-aggressive branch housekeeping on my repo fork. |
Adds tooling to generate and test an iOS XCframework, in a way that will also facilitate adding other XCframework targets for other Apple platforms (tvOS, watchOS, visionOS and even macOS, potentially).
Co-authored-by: Hugo van Kemenade [email protected]
(cherry picked from commit 35c7e52)
This doesn't alter anything in the operation of iOS; it moves the location of the testbed, and adds the tooling to coordinate XCframework builds. This will potentially allow for a binary release in a 3.14 point release; but at the very least, will make back porting efforts easier in the meantime.