Skip to content

Conversation

Yassir-aykhlf
Copy link

This PR adds type hints to improve code quality and developer experience.

Changes:

  • Added type annotations to all 8 functions in patchcheck.py
  • Added necessary typing imports (Callable, Optional)
  • Applied ruff formatting for consistency

Testing:

  • Verified patchcheck.py runs successfully
  • No functional changes, only type annotations added
  • Follows modern Python typing conventions (PEP 585)

- Added type annotations to all functions
- Added typing imports (Callable, Optional)
- Applied ruff formatting for consistency
@python-cla-bot
Copy link

python-cla-bot bot commented Sep 29, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

This comment was marked as resolved.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all unrelated changes, including but not limited to formatting.

In general though I'm not sure we need type annotations here, so we may end up closing the PR.

A

@bedevere-app
Copy link

bedevere-app bot commented Sep 29, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll also add to Adam's comment, if this is to be done it should be tested with mypy in our CI.

@ZeroIntensity
Copy link
Member

I'm going to close this. There's benefit to having type hints in our internal tooling, but this is going to inspire copycat PRs. If you're interested in contributing, please take a look at our developer guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants