-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-93963: Officially deprecate abcs and warn about their usage. #93965
gh-93963: Officially deprecate abcs and warn about their usage. #93965
Conversation
2064d07
to
7890672
Compare
7890672
to
5e7fb9c
Compare
Co-authored-by: Thomas Grainger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you note the deprecations in https://docs.python.org/3.12/library/importlib.html with deprecated-removed
?
and list under https://docs.python.org/3.12/whatsnew/3.12.html#pending-removal-in-python-3-13 ?
According to PEP 387, if these are being deprecated in 3.12, is 3.14 the earliest they can be removed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some questions.
When you're done making the requested changes, leave the comment: |
Honestly, I don't think all this is necessary. What would be the harm if they stay importable from both places? |
From a backward compatibility question, none. But we should be crisp in the documentation about where the proper place to import them from is, and add deprecations for the old places. |
Yes, although I contend it would be preferable to deprecate these in 3.11 for removal in 3.13, given that is the prior intention. |
Okay! I thought the 3.11 beta period was too late for new deprecations, but let's check with @pablogsal to see if this can be backported to 3.11. |
Indeed, unfortunately is too late to add new deprecations to 3.11, specially given how unstable 3.11 is already. Sadly this needs to be done starting in 3.12 :( |
I have made the requested changes; please review again. |
Thanks for making the requested changes! @warsaw: please review the changes made to this pull request. |
Fixes #93963
Automerge-Triggered-By: GH:jaraco