Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recommended locales to the testing document #1187

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Add recommended locales to the testing document #1187

merged 3 commits into from
Oct 13, 2023

Conversation

willingc
Copy link
Collaborator

@willingc willingc commented Oct 11, 2023 •
edited by github-actions bot
Loading

Closes #874

📚 Documentation preview 📚: https://cpython-devguide--1187.org.readthedocs.build/

ezio-melotti
ezio-melotti reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also include brief instructions and/or links on how to install them?
A single sentence like "You can list the installed locales using some-command -l and install new ones using some-command en_US." might be enough.

testing/run-write-tests.rst Outdated Show resolved Hide resolved
@willingc willingc merged commit 74e0165 into python:main Oct 13, 2023
2 checks passed
@willingc willingc deleted the iss874 branch October 13, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti ezio-melotti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recommend setting up more locales
2 participants
@willingc @ezio-melotti