Remove/update references to EOL Python versions #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -834,8 +834,7 @@ To save time, and to minimize how much you need to learn | |||
| to achieve your first port to Argument Clinic, the walkthrough above tells | |||
| you to use "legacy converters". "Legacy converters" are a convenience, | |||
| designed explicitly to make porting existing code to Argument Clinic | |||
| easier. And to be clear, their use is acceptable when porting code for | |||
| Python 3.4. | |||
| easier. | |||
There was a problem hiding this comment.
Maybe this sentence is useful since it's about legacy converters? @erlend-aasland?
There was a problem hiding this comment.
I don't understand this sentence. IIRC, legacy converters are just aliases for "normal" converters. I can take a closer look tomorrow. Ping me again if I take too long.
There was a problem hiding this comment.
I'm fine with removing this. AFAICS, it has no relevance anymore. If it causes great havoc, I'll take the blame :)
erlend-aasland
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #661.
We've already removed quite a few other old ones, such as instructions for building older Python versions.
📚 Documentation preview 📚: https://cpython-devguide--1227.org.readthedocs.build/