Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119786: move 'exploring' doc from devguide to InternalDocs #1456

Closed
wants to merge 2 commits into from

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Oct 23, 2024

@iritkatriel iritkatriel requested a review from nedbat October 23, 2024 18:00
@nedbat
Copy link
Member

nedbat commented Oct 23, 2024

I think it might make sense to leave this in the devguide. It is overview and will not change frequently. People might need this kind of help to find their way into the cpython repo.

@iritkatriel
Copy link
Member Author

I think it might make sense to leave this in the devguide. It is overview and will not change frequently. People might need this kind of help to find their way into the cpython repo.

I'm happy to leave the directory structure overview.

The second part (links to external resources) does seem to fit with the internals docs, though. Do you agree?

@willingc
Copy link
Collaborator

Here's what I think makes sense. I think this should remain in the developer/contributor guide for now. I think it is also fine to copy the contents to the Internals Doc in the CPython repo.

The source code layout is helpful for people navigating contribution.

Most of the resources are general and written by external individuals. We may want to curate this list.

So that, then begs the question of duplication of information which is not necessarily bad. I could see the docs diverging over time. CPython repo containing low level implementation details and contribution guide providing a pathway to understanding the internals. In the contribution guide, we can provide the content and guide the reader to the internals documentation which should be the source of truth after the source code on internals.

@willingc
Copy link
Collaborator

Just curious since I wasn't able to attend the sprint to ask you in person @iritkatriel, what is the vision and primary purpose for the internal docs? I want to make sure that I have a sense of what the expectation of the Internals Docs relative to the other documentation in the project ☀️

@iritkatriel
Copy link
Member Author

Just curious since I wasn't able to attend the sprint to ask you in person @iritkatriel, what is the vision and primary purpose for the internal docs? I want to make sure that I have a sense of what the expectation of the Internals Docs relative to the other documentation in the project ☀️

The problems I'm trying to solve are

  1. documentation on internals was scattered in several places so not easy to discover.
  2. it was not in the same repo as the code, which made it less likely to be kept up to date (now you update it in the same PR as the code change)
  3. It wasn't versioned in the devguide, so once it's updated to the current dev version we lose information about previous versions which are still supported (or, we need to have the same doc discuss different versions, which can be confusing). In the future, the docs for older versions will remain in the repo in that tag.
  4. Quality is inconsistent as some of the internal doc are not very polished. They are also incomplete, but we don't have a view of what's missing.

@willingc
Copy link
Collaborator

Thanks @iritkatriel. That's super helpful re: scattered docs which I agree with. I'm curious about thinking about the CPython docs, Internals Docs, and dev/contributor guide, and having a clearer strategy moving forward.

For now my recommendation, would be to move to the InternalsDocs and also leave here.

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's close this PR but go ahead with merging the CPython PR. Leaving the Devguide contents unchanged for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants