-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-119786: move 'exploring' doc from devguide to InternalDocs #1456
Conversation
I think it might make sense to leave this in the devguide. It is overview and will not change frequently. People might need this kind of help to find their way into the cpython repo. |
I'm happy to leave the directory structure overview. The second part (links to external resources) does seem to fit with the internals docs, though. Do you agree? |
Here's what I think makes sense. I think this should remain in the developer/contributor guide for now. I think it is also fine to copy the contents to the Internals Doc in the CPython repo. The source code layout is helpful for people navigating contribution. Most of the resources are general and written by external individuals. We may want to curate this list. So that, then begs the question of duplication of information which is not necessarily bad. I could see the docs diverging over time. CPython repo containing low level implementation details and contribution guide providing a pathway to understanding the internals. In the contribution guide, we can provide the content and guide the reader to the internals documentation which should be the source of truth after the source code on internals. |
Just curious since I wasn't able to attend the sprint to ask you in person @iritkatriel, what is the vision and primary purpose for the internal docs? I want to make sure that I have a sense of what the expectation of the Internals Docs relative to the other documentation in the project ☀️ |
The problems I'm trying to solve are
|
Thanks @iritkatriel. That's super helpful re: scattered docs which I agree with. I'm curious about thinking about the CPython docs, Internals Docs, and dev/contributor guide, and having a clearer strategy moving forward. For now my recommendation, would be to move to the InternalsDocs and also leave here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's close this PR but go ahead with merging the CPython PR. Leaving the Devguide contents unchanged for now.
📚 Documentation preview 📚: https://cpython-devguide--1456.org.readthedocs.build/