Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul the labels page to reflect current GH labeling practice #930

Merged
merged 22 commits into from
Mar 16, 2023

Conversation

ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented Aug 6, 2022

This PR updates the triage/labels.rst page, that contained outdated references to removed/renamed labels and previous fields used by bpo.

The PR is still a draft. The first commit documents the existing labels. Next, most of the remaining text in the page will either be deleted or moved to other sections, since it mostly covers bpo fields. Finally, I might add more links to the relevant sections to avoid duplicating information.

This is part of https://github.com/orgs/python/projects/25 and will fix the following issues:

Fixes #296
Fixes #518
Fixes #821
Fixes #868
Fixes #929

The structure and grouping of the labels is also based on python/core-workflow#450

@terryjreedy
Copy link
Member

I don't see any mention of automerge in the patch, but see comment on #518.

@ezio-melotti
Copy link
Member Author

I haven't used automerge myself so, even though I'm planning to document it, I first have to figure out how it works exactly, and when it should be used.

triage/issue-tracker.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
@ezio-melotti ezio-melotti marked this pull request as ready for review December 25, 2022 08:03
@ezio-melotti
Copy link
Member Author

I updated the PR and marked it as "ready for review". It's still not perfect, but we can start merging this and apply further improvements in separate PRs. I left some inline comments to facilitate the review.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezio-melotti , this seems like a great set of major and well-needed improvements overall. I did have a number of specific suggestions for tweaks, most minor and a few less so, as well as a handful of broader comments and questions. Thanks!

triage/issue-tracker.rst Outdated Show resolved Hide resolved
triage/issue-tracker.rst Outdated Show resolved Hide resolved
triage/issue-tracker.rst Outdated Show resolved Hide resolved
triage/issue-tracker.rst Outdated Show resolved Hide resolved
triage/triage-team.rst Outdated Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/issue-tracker.rst Outdated Show resolved Hide resolved
triage/issue-tracker.rst Outdated Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/issue-tracker.rst Outdated Show resolved Hide resolved
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

Some suggestions mostly about preserving #anchors where appropriate.

triage/triage-team.rst Outdated Show resolved Hide resolved
triage/triage-team.rst Outdated Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Outdated Show resolved Hide resolved
triage/labels.rst Outdated Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Outdated Show resolved Hide resolved
ezio-melotti and others added 2 commits December 27, 2022 09:50
@hugovk
Copy link
Member

hugovk commented Feb 11, 2023

This PR could also close #296.

@CAM-Gerlach CAM-Gerlach changed the title Update the triage/labels.rst page. Overhaul the labels page to reflect current GH labeling practice Feb 14, 2023
@CAM-Gerlach
Copy link
Member

It wouldn't let me add that one under Development for whatever reason, so I edited the OP directly (and made the others proper fix-tagged). I also fixed the title to be more useful/descriptive and less generic; refine it further as desired, of course.

Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏷️ Thank you!

@CAM-Gerlach CAM-Gerlach self-requested a review March 15, 2023 08:01
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a handful of final followups, ref target label tweaks and a few other fixes I spotted—all as one-click apply able suggestions—plus re-iterating one previous unresolved comment requesting reverting the "assignee" section removal that has no existing replacement, and should be iterated on in the future. Other than that, LGTM, and I resolved the other outstanding comments (aside from a couple addressed here). Thanks @ezio-melotti for all your hard work (and patience) here!

triage/labels.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/triage-team.rst Outdated Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Show resolved Hide resolved
triage/labels.rst Outdated Show resolved Hide resolved
triage/labels.rst Outdated Show resolved Hide resolved
triage/labels.rst Outdated Show resolved Hide resolved
triage/labels.rst Outdated Show resolved Hide resolved
triage/triaging.rst Outdated Show resolved Hide resolved
triage/triaging.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <[email protected]>
@CAM-Gerlach CAM-Gerlach self-requested a review March 16, 2023 14:49
Co-authored-by: Hugo van Kemenade <[email protected]>
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few final followup fixes and one minor thing I couldn't reach (that may be out of scope), otherwise LGTM, thanks! Marked everything else as resolved now.

triage/triaging.rst Outdated Show resolved Hide resolved
triage/triaging.rst Outdated Show resolved Hide resolved
triage/triaging.rst Outdated Show resolved Hide resolved
triage/labels.rst Outdated Show resolved Hide resolved
triage/labels.rst Outdated Show resolved Hide resolved
Co-authored-by: C.A.M. Gerlach <[email protected]>
@ezio-melotti ezio-melotti merged commit 4e6e10f into python:main Mar 16, 2023
@ezio-melotti ezio-melotti deleted the update-labels branch March 16, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment