-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul the labels page to reflect current GH labeling practice #930
Conversation
I don't see any mention of automerge in the patch, but see comment on #518. |
I haven't used |
I updated the PR and marked it as "ready for review". It's still not perfect, but we can start merging this and apply further improvements in separate PRs. I left some inline comments to facilitate the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ezio-melotti , this seems like a great set of major and well-needed improvements overall. I did have a number of specific suggestions for tweaks, most minor and a few less so, as well as a handful of broader comments and questions. Thanks!
Co-authored-by: C.A.M. Gerlach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
Some suggestions mostly about preserving #anchors
where appropriate.
Co-authored-by: C.A.M. Gerlach <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
This PR could also close #296. |
It wouldn't let me add that one under |
Co-authored-by: C.A.M. Gerlach <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏷️ Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a handful of final followups, ref target label tweaks and a few other fixes I spotted—all as one-click apply able suggestions—plus re-iterating one previous unresolved comment requesting reverting the "assignee" section removal that has no existing replacement, and should be iterated on in the future. Other than that, LGTM, and I resolved the other outstanding comments (aside from a couple addressed here). Thanks @ezio-melotti for all your hard work (and patience) here!
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few final followup fixes and one minor thing I couldn't reach (that may be out of scope), otherwise LGTM, thanks! Marked everything else as resolved now.
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
This PR updates the
triage/labels.rst
page, that contained outdated references to removed/renamed labels and previous fields used by bpo.The PR is still a draft. The first commit documents the existing labels. Next, most of the remaining text in the page will either be deleted or moved to other sections, since it mostly covers bpo fields. Finally, I might add more links to the relevant sections to avoid duplicating information.
This is part of https://github.com/orgs/python/projects/25 and will fix the following issues:
Fixes #296
Fixes #518
Fixes #821
Fixes #868
Fixes #929
The structure and grouping of the labels is also based on python/core-workflow#450