Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify copying robots.txt #215

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Simplify copying robots.txt #215

merged 1 commit into from
Oct 9, 2024

Conversation

AA-Turner
Copy link
Member

robots.txt does not and has never used template variables. This removes the needless Jinja steps and simply copies the file.

A

hugovk
hugovk approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not a template, should robots.txt be moved out of templates/?

Fine to leave it there if no better home.

@AA-Turner
Copy link
Member Author

Fine to leave it there if no better home.

This was my thinking; 404.html is in the same boat.

A

@AA-Turner AA-Turner merged commit 65c2c30 into python:main Oct 9, 2024
5 checks passed
@AA-Turner AA-Turner deleted the robots_txt branch October 9, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AA-Turner @hugovk