Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing multiple branches to build via CLI #235

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 8, 2024

A full set of Python 3.9-3.13 security+bugfix releases were made last week:

https://discuss.python.org/t/python-3-13-1-3-12-8-3-11-11-3-10-16-and-3-9-21-are-now-available/73214

The bugfix branches (3.12 and 3.13) are automatically built on cron.

The security branches (3.9-3.11) need manual rebuilds. We also have the final 3.8 to manually run. It's taken 16 and 13 hours for a full build of the first two so far (3.11 and 3.10; see #216).

We will certainly have big omnibus security releases in the future and instead of having to run each one separately:

/srv/docsbuild/venv/bin/python /srv/docsbuild/scripts/build_docs.py --branch 3.11
/srv/docsbuild/venv/bin/python /srv/docsbuild/scripts/build_docs.py --branch 3.10
/srv/docsbuild/venv/bin/python /srv/docsbuild/scripts/build_docs.py --branch 3.9
/srv/docsbuild/venv/bin/python /srv/docsbuild/scripts/build_docs.py --branch 3.8

It would be useful to pass all branch versions, in a similar way we can with --languages:

/srv/docsbuild/venv/bin/python /srv/docsbuild/scripts/build_docs.py --branch 3.11 3.10 3.9 3.8

This PR does that.

I added unit tests for the Version.filter method I changed, along with coverage. We can use coverage to guide adding more tests in the future.


I also added --branches as a new name for this argument and kept the old --branch so as not to break any other scripts, but we could change it later.

We could also make it's use more explicitly deprecated, like print a warning if --branch is used? Maybe it's safe to rename it right away?

@hugovk hugovk mentioned this pull request Dec 8, 2024
@hugovk hugovk changed the title Allow passing multiple branches build via CLI Allow passing multiple branches to build via CLI Dec 8, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants