Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "not callable" issue for @dataclass(frozen=True) with Final attr #18572

Merged
merged 2 commits into from
Feb 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mypy/plugins/dataclasses.py
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,8 @@ def _freeze(self, attributes: list[DataclassAttribute]) -> None:
if sym_node is not None:
var = sym_node.node
if isinstance(var, Var):
if var.is_final:
continue # do not turn `Final` attrs to `@property`
var.is_property = True
else:
var = attr.to_var(info)
Expand Down
23 changes: 23 additions & 0 deletions test-data/unit/check-dataclasses.test
Original file line number Diff line number Diff line change
Expand Up @@ -2553,3 +2553,26 @@ class X(metaclass=DCMeta):
class Y(X):
a: int # E: Covariant override of a mutable attribute (base class "X" defined the type as "Optional[int]", expression has type "int")
[builtins fixtures/tuple.pyi]


[case testFrozenWithFinal]
from dataclasses import dataclass
from typing import Final

@dataclass(frozen=True)
class My:
a: Final = 1
b: Final[int] = 2

reveal_type(My.a) # N: Revealed type is "Literal[1]?"
reveal_type(My.b) # N: Revealed type is "builtins.int"
My.a = 1 # E: Cannot assign to final attribute "a"
My.b = 2 # E: Cannot assign to final attribute "b"

m = My()
reveal_type(m.a) # N: Revealed type is "Literal[1]?"
reveal_type(m.b) # N: Revealed type is "builtins.int"

m.a = 1 # E: Cannot assign to final attribute "a"
m.b = 2 # E: Cannot assign to final attribute "b"
[builtins fixtures/tuple.pyi]