feat(test): Failure test case for mypyc dictionary subclass views #19076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended to create a failing test case for the bug seen here: https://github.com/BobTheBuidler/checksum_dict/actions/runs/14843222374/job/41670896987
BobTheBuidler
changed the title
|
@JukkaL Would you happen to know what I need to change so the tests are able to find the DefaultDict object in the typing module? Or is there someone better to ask about this? |
|
Fascinating, I've managed to make it work using a type: ignore comment, and now we have our successful (wut?) failure case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a failing test case for a mypyc bug with dict views as seen here: https://github.com/BobTheBuidler/checksum_dict/actions/runs/14843222374/job/41670896987
I added some new (working) test cases:
and the failure cases: