Traverse type alias args in collect visitor

[ilevkivskyi]

Fixes #19941

Fix is trivial (and a bit embarrassing, LOL).

[github-actions]

Diff from mypy_primer, showing the effect of this PR on open source code:

graphql-core (https://github.com/graphql-python/graphql-core)
- src/graphql/execution/incremental_publisher.py:1057: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
- https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
- Please report a bug at https://github.com/python/mypy/issues
- version: 1.19.0+dev.89f7223b57db2a7a6188767988481dd81b58e14c
- src/graphql/execution/incremental_publisher.py:1057: : note: use --pdb to drop into pdb
- Traceback (most recent call last):
-   File "", line 7, in <module>
-     sys.exit(console_entry())
-   File "/__main__.py", line 15, in console_entry
-     main()
-   File "/main.py", line 127, in main
-     res, messages, blockers = run_build(sources, options, fscache, t0, stdout, stderr)
-   File "/main.py", line 211, in run_build
-     res = build.build(sources, options, None, flush_errors, fscache, stdout, stderr)
-   File "/build.py", line 196, in build
-     result = _build(
-   File "/build.py", line 272, in _build
-     graph = dispatch(sources, manager, stdout)
-   File "/build.py", line 2946, in dispatch
-     process_graph(graph, manager)
-   File "/build.py", line 3346, in process_graph
-     process_stale_scc(graph, scc, manager)
-   File "/build.py", line 3447, in process_stale_scc
-     graph[id].type_check_first_pass()
-   File "/build.py", line 2325, in type_check_first_pass
-     self.type_checker().check_first_pass()
-   File "/checker.py", line 524, in check_first_pass
-     self.accept(d)
-   File "/checker.py", line 635, in accept
-     stmt.accept(self)
-   File "/nodes.py", line 1445, in accept
-     return visitor.visit_class_def(self)
-   File "/checker.py", line 2665, in visit_class_def
-     self.accept(defn.defs)
-   File "/checker.py", line 635, in accept
-     stmt.accept(self)
-   File "/nodes.py", line 1542, in accept
-     return visitor.visit_block(self)
-   File "/checker.py", line 3126, in visit_block
-     self.accept(s)
-   File "/checker.py", line 635, in accept
-     stmt.accept(self)
-   File "/nodes.py", line 971, in accept
-     return visitor.visit_func_def(self)
-   File "/checker.py", line 1192, in visit_func_def
-     self._visit_func_def(defn)
-   File "/checker.py", line 1196, in _visit_func_def
-     self.check_func_item(defn, name=defn.name)
-   File "/checker.py", line 1231, in check_func_item
-     self.check_func_def(defn, typ, name, allow_empty)
-   File "/checker.py", line 1504, in check_func_def
-     self.accept(item.body)
-   File "/checker.py", line 635, in accept
-     stmt.accept(self)
-   File "/nodes.py", line 1542, in accept
-     return visitor.visit_block(self)
-   File "/checker.py", line 3126, in visit_block
-     self.accept(s)
-   File "/checker.py", line 635, in accept
-     stmt.accept(self)
-   File "/nodes.py", line 1723, in accept
-     return visitor.visit_for_stmt(self)
-   File "/checker.py", line 5284, in visit_for_stmt
-     self.accept_loop(
-   File "/checker.py", line 667, in accept_loop
-     self.accept(body)
-   File "/checker.py", line 635, in accept
-     stmt.accept(self)
-   File "/nodes.py", line 1542, in accept
-     return visitor.visit_block(self)
-   File "/checker.py", line 3126, in visit_block
-     self.accept(s)
-   File "/checker.py", line 635, in accept
-     stmt.accept(self)
-   File "/nodes.py", line 1810, in accept
-     return visitor.visit_if_stmt(self)
-   File "/checker.py", line 5031, in visit_if_stmt
-     self.accept(s.else_body)
-   File "/checker.py", line 635, in accept
-     stmt.accept(self)
-   File "/nodes.py", line 1542, in accept
-     return visitor.visit_block(self)
-   File "/checker.py", line 3126, in visit_block
-     self.accept(s)
-   File "/checker.py", line 635, in accept
-     stmt.accept(self)
-   File "/nodes.py", line 1562, in accept
-     return visitor.visit_expression_stmt(self)
-   File "/checker.py", line 4842, in visit_expression_stmt
-     expr_type = self.expr_checker.accept(s.expr, allow_none_return=True, always_allow_any=True)
-   File "/checkexpr.py", line 6020, in accept
-     typ = self.visit_call_expr(node, allow_none_return=True)
-   File "/checkexpr.py", line 494, in visit_call_expr
-     return self.visit_call_expr_inner(e, allow_none_return=allow_none_return)
-            ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   File "/checkexpr.py", line 631, in visit_call_expr_inner
-     ret_type = self.check_call_expr_with_callee_type(
-         callee_type, e, fullname, object_type, member
-     )
-   File "/checkexpr.py", line 1481, in check_call_expr_with_callee_type
-     ret_type, callee_type = self.check_call(
-                             ~~~~~~~~~~~~~~~^
-         callee_type,
-         ^^^^^^^^^^^^
-     ...<6 lines>...
-         object_type=object_type,
-         ^^^^^^^^^^^^^^^^^^^^^^^^
-     )
-     ^
-   File "/checkexpr.py", line 1574, in check_call
-     return self.check_callable_call(
-            ~~~~~~~~~~~~~~~~~~~~~~~~^
-         callee,
-         ^^^^^^^
-     ...<6 lines>...
-         object_type,
-         ^^^^^^^^^^^^
-     )
-     ^
-   File "/checkexpr.py", line 1798, in check_callable_call
-     self.check_argument_types(
-     ~~~~~~~~~~~~~~~~~~~~~~~~~^
-         arg_types, arg_kinds, args, callee, formal_to_actual, context, object_type=object_type
-         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-     )
-     ^
-   File "/checkexpr.py", line 2612, in check_argument_types
-     check_arg(
-     ~~~~~~~~~^
-         expanded_actual,
-         ^^^^^^^^^^^^^^^^
-     ...<8 lines>...
-         context,
-         ^^^^^^^^
-     )
-     ^
-   File "/checkexpr.py", line 2649, in check_arg
-     error = self.msg.incompatible_argument(
-         n,
-     ...<6 lines>...
-         outer_context=outer_context,
-     )
-   File "/messages.py", line 782, in incompatible_argument
-     arg_type_str, expected_type_str = format_type_distinctly(
-                                       ~~~~~~~~~~~~~~~~~~~~~~^
-         arg_type, expected_type, bare=True, options=self.options
-         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-     )
-     ^
-   File "/messages.py", line 2900, in format_type_distinctly
-     overlapping = find_type_overlaps(*types)
-   File "/messages.py", line 2836, in find_type_overlaps
-     for t in collect_all_named_types(type):
-              ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2788, in collect_all_named_types
-     t.accept(visitor)
-     ~~~~~~~~^^^^^^^^^
-   File "/types.py", line 3334, in accept
-     return visitor.visit_union_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/typetraverser.py", line 105, in visit_union_type
-     self.traverse_type_list(t.items)
-     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
-   File "/typetraverser.py", line 154, in traverse_type_list
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 1634, in accept
-     return visitor.visit_instance(self)
-            ~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2798, in visit_instance
-     super().visit_instance(t)
-     ~~~~~~~~~~~~~~~~~~~~~~^^^
-   File "/typetraverser.py", line 82, in visit_instance
-     self.traverse_type_tuple(t.args)
-     ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
-   File "/typetraverser.py", line 159, in traverse_type_tuple
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 406, in accept
-     return visitor.visit_type_alias_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2802, in visit_type_alias_type
-     get_proper_type(t).accept(self)
-     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/types.py", line 3334, in accept
-     return visitor.visit_union_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/typetraverser.py", line 105, in visit_union_type
-     self.traverse_type_list(t.items)
-     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
-   File "/typetraverser.py", line 154, in traverse_type_list
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 406, in accept
-     return visitor.visit_type_alias_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2802, in visit_type_alias_type
-     get_proper_type(t).accept(self)
-     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/types.py", line 2773, in accept
-     return visitor.visit_tuple_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/typetraverser.py", line 97, in visit_tuple_type
-     self.traverse_type_list(t.items)
-     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
-   File "/typetraverser.py", line 154, in traverse_type_list
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 1634, in accept
-     return visitor.visit_instance(self)
-            ~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2798, in visit_instance
-     super().visit_instance(t)
-     ~~~~~~~~~~~~~~~~~~~~~~^^^
-   File "/typetraverser.py", line 82, in visit_instance
-     self.traverse_type_tuple(t.args)
-     ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
-   File "/typetraverser.py", line 159, in traverse_type_tuple
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 406, in accept
-     return visitor.visit_type_alias_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2802, in visit_type_alias_type
-     get_proper_type(t).accept(self)
-     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/types.py", line 3334, in accept
-     return visitor.visit_union_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/typetraverser.py", line 105, in visit_union_type
-     self.traverse_type_list(t.items)
-     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
-   File "/typetraverser.py", line 154, in traverse_type_list
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 406, in accept
-     return visitor.visit_type_alias_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2802, in visit_type_alias_type
-     get_proper_type(t).accept(self)
-     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/types.py", line 2773, in accept
-     return visitor.visit_tuple_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/typetraverser.py", line 97, in visit_tuple_type
-     self.traverse_type_list(t.items)
-     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
-   File "/typetraverser.py", line 154, in traverse_type_list
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 406, in accept
-     return visitor.visit_type_alias_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2802, in visit_type_alias_type
-     get_proper_type(t).accept(self)
-     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/types.py", line 3334, in accept
-     return visitor.visit_union_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/typetraverser.py", line 105, in visit_union_type
-     self.traverse_type_list(t.items)
-     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
-   File "/typetraverser.py", line 154, in traverse_type_list
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 1634, in accept
-     return visitor.visit_instance(self)
-            ~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2798, in visit_instance
-     super().visit_instance(t)
-     ~~~~~~~~~~~~~~~~~~~~~~^^^
-   File "/typetraverser.py", line 82, in visit_instance
-     self.traverse_type_tuple(t.args)
-     ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
-   File "/typetraverser.py", line 159, in traverse_type_tuple
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 406, in accept
-     return visitor.visit_type_alias_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2802, in visit_type_alias_type
-     get_proper_type(t).accept(self)
-     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/types.py", line 3334, in accept
-     return visitor.visit_union_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/typetraverser.py", line 105, in visit_union_type
-     self.traverse_type_list(t.items)
-     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
-   File "/typetraverser.py", line 154, in traverse_type_list
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 406, in accept
-     return visitor.visit_type_alias_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2802, in visit_type_alias_type
-     get_proper_type(t).accept(self)
-     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/types.py", line 2773, in accept
-     return visitor.visit_tuple_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/typetraverser.py", line 97, in visit_tuple_type
-     self.traverse_type_list(t.items)
-     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
-   File "/typetraverser.py", line 154, in traverse_type_list
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 1634, in accept
-     return visitor.visit_instance(self)
-            ~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2798, in visit_instance
-     super().visit_instance(t)
-     ~~~~~~~~~~~~~~~~~~~~~~^^^
-   File "/typetraverser.py", line 82, in visit_instance
-     self.traverse_type_tuple(t.args)
-     ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
-   File "/typetraverser.py", line 159, in traverse_type_tuple
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 406, in accept
-     return visitor.visit_type_alias_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2802, in visit_type_alias_type
-     get_proper_type(t).accept(self)
-     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/types.py", line 3334, in accept
-     return visitor.visit_union_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/typetraverser.py", line 105, in visit_union_type
-     self.traverse_type_list(t.items)
-     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
-   File "/typetraverser.py", line 154, in traverse_type_list
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 406, in accept
-     return visitor.visit_type_alias_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2802, in visit_type_alias_type
-     get_proper_type(t).accept(self)
-     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/types.py", line 2773, in accept
-     return visitor.visit_tuple_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/typetraverser.py", line 97, in visit_tuple_type
-     self.traverse_type_list(t.items)
-     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
-   File "/typetraverser.py", line 154, in traverse_type_list
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 406, in accept
-     return visitor.visit_type_alias_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2802, in visit_type_alias_type
-     get_proper_type(t).accept(self)
-     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/types.py", line 3334, in accept
-     return visitor.visit_union_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/typetraverser.py", line 105, in visit_union_type
-     self.traverse_type_list(t.items)
-     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
-   File "/typetraverser.py", line 154, in traverse_type_list
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 1634, in accept
-     return visitor.visit_instance(self)
-            ~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2798, in visit_instance
-     super().visit_instance(t)
-     ~~~~~~~~~~~~~~~~~~~~~~^^^
-   File "/typetraverser.py", line 82, in visit_instance
-     self.traverse_type_tuple(t.args)
-     ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
-   File "/typetraverser.py", line 159, in traverse_type_tuple
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 406, in accept
-     return visitor.visit_type_alias_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/messages.py", line 2802, in visit_type_alias_type
-     get_proper_type(t).accept(self)
-     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/types.py", line 3334, in accept
-     return visitor.visit_union_type(self)
-            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
-   File "/typetraverser.py", line 105, in visit_union_type
-     self.traverse_type_list(t.items)
-     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
-   File "/typetraverser.py", line 154, in traverse_type_list
-     typ.accept(self)
-     ~~~~~~~~~~^^^^^^
-   File "/types.py", line 406, in accept
-     return visitor.visit_type_alias_type(self)

... (truncated 48754 lines) ...

[hauntsaninja]

:-)