Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 726: Fix error message description #3562

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

Rosuav
Copy link
Contributor

@Rosuav Rosuav commented Dec 2, 2023

Zero is a non-negative number, but since zero is being excluded here, the check is really ensuring that it is a positive number.


📚 Documentation preview 📚: https://pep-previews--3562.org.readthedocs.build/

Zero is a non-negative number, but since zero is being excluded here, the
check is really ensuring that it is a positive number.
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also fix this typo:

peps/pep-0726.rst:282: overriden ==> overridden

@ambv
Copy link
Contributor

ambv commented Dec 11, 2023

The RTD build failure is unrelated. I filed #3583 to track it.

@hugovk
Copy link
Member

hugovk commented Dec 12, 2023

The build failure is caused by pypa/packaging.python.org#1434 and already fixed in main: #3563.

@hugovk hugovk merged commit 108ca0a into python:main Dec 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants