Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 612: Mark as Final #3575

Merged
merged 6 commits into from
Jan 12, 2024
Merged

PEP 612: Mark as Final #3575

merged 6 commits into from
Jan 12, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 10, 2023

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive (or canonical-pypa-spec, for packaging PEPs)

Helps #2872 and #3579.

Link to https://docs.python.org/3/library/typing.html#typing.ParamSpec as the canonical docs, and remove a redundant header.

cc @Fidget-Spinner


📚 Documentation preview 📚: https://pep-previews--3575.org.readthedocs.build/pep-0612/

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment

peps/pep-0612.rst Outdated Show resolved Hide resolved
@hugovk hugovk mentioned this pull request Dec 10, 2023
6 tasks
peps/pep-0612.rst Outdated Show resolved Hide resolved
@brettcannon brettcannon removed their request for review January 11, 2024 19:03
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk merged commit f7f9f2d into python:main Jan 12, 2024
23 checks passed
@hugovk hugovk deleted the pep612-mark-as-final branch January 15, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants