Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 740: data-provenance attribute value tweaks #3971

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

woodruffw
Copy link
Contributor

@woodruffw woodruffw commented Sep 17, 2024

Opening this up for discussion: @di observed that the current provisional requirement (that the provenance be pinned by SHA-256) has no security impact, since the provenance contains digitally signatures objects that will fail to verify if tampered with.

At the same time, the index APIs still need some way to signal that the provenance object is actually present. This tweaks the provisional language to have the index serve a URL to the provenance object.


📚 Documentation preview 📚: https://pep-previews--3971.org.readthedocs.build/

Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Copy link
Sponsor Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit for clairity.

peps/pep-0740.rst Outdated Show resolved Hide resolved
Co-authored-by: Dustin Ingram <[email protected]>
@AA-Turner
Copy link
Member

Close/open for CLA check.

@AA-Turner AA-Turner closed this Sep 23, 2024
@AA-Turner AA-Turner reopened this Sep 23, 2024
@AA-Turner
Copy link
Member

@woodruffw likewise, ready for merge?

A

@AA-Turner AA-Turner changed the title PEP 740: data-provenance attribute value tweaks PEP 740: data-provenance attribute value tweaks Sep 23, 2024
@woodruffw
Copy link
Contributor Author

@woodruffw likewise, ready for merge?

Yep as well, thanks!

@AA-Turner AA-Turner merged commit b92dd15 into python:main Sep 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants