Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 738: Mark as Final #3982

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

PEP 738: Mark as Final #3982

wants to merge 6 commits into from

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Sep 20, 2024

The Android x86_64 buildbot is not yet up and running, so this is not quite ready to be merged. The aarch64 and x86_64 buildbots are both now stable.

@freakboy3742: I assume you're OK with being added as a second core team contact for Android?


📚 Documentation preview 📚: https://pep-previews--3982.org.readthedocs.build/

Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that yes - I'm OK being added as a contact for Android platform support.

One other comment inline.

peps/pep-0738.rst Show resolved Hide resolved
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being thorough here! There is a small changed needed to fix the intersphinx links to the canonical doc; it should be straightforward but I can commit it for you if you like.

peps/pep-0738.rst Outdated Show resolved Hide resolved
@mhsmith mhsmith changed the title PEP 738: Mark Final, and add Android to PEP 11 PEP 738: Mark Final Sep 23, 2024
@mhsmith mhsmith mentioned this pull request Sep 23, 2024
4 tasks
@AA-Turner AA-Turner changed the title PEP 738: Mark Final PEP 738: Mark as Final Oct 1, 2024
@AA-Turner
Copy link
Member

AA-Turner commented Oct 1, 2024

@mhsmith is there anything outstanding on this PR? [Edit: waiting for 3.13.0 final release for the using-android target to work]

A

Type: Standards Track
Created: 12-Dec-2023
Python-Version: 3.13
Resolution: https://discuss.python.org/t/pep-738-adding-android-as-a-supported-platform/40975/23

.. canonical-doc:: :ref:`python:using-android`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to wait, we can point to the 3.13 docs using py3.13, like we're already doing for in other PEPs:

Suggested change
.. canonical-doc:: :ref:`python:using-android`
.. canonical-doc:: :external+py3.13:ref:`using-android`

Copy link
Member Author

@mhsmith mhsmith Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, we might as well wait a week for the /3/ URL to become valid, which will save the effort of updating it again.

@mhsmith
Copy link
Member Author

mhsmith commented Oct 1, 2024

@AA-Turner changed the title PEP 738: Mark Final PEP 738: Mark as Final

You might want to update the title instructions in the PR template.

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mhsmith. Do you want to take this PR out of draft mode?

@mhsmith mhsmith marked this pull request as ready for review October 2, 2024 21:09
@mhsmith mhsmith requested a review from encukou as a code owner October 2, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Android as a target platform
6 participants