Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 735: apply community feedback, including reversion of [project] table changes #3990

Merged
merged 10 commits into from
Oct 1, 2024

Commits on Sep 23, 2024

  1. Remove [project] changes from Dependency Groups

    In response to feedback, and especially to the points about ecosystem
    impacts and encouraging users to move package metadata out of the
    current standard location, remove support for Dependency Group
    Includes in the `[project]` table.
    
    This is now listed with rationale in Rejected Ideas, and several
    sections have been updated for correctness to fit this removal.
    sirosen committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b87b396 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    958a442 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3d99a05 View commit details
    Browse the repository at this point in the history
  4. More strongly discourage overlapping extras

    In "PEP 735: Dependency Groups", the defined semantics for a potential
    name conflict between an extra and a group discouraged tools from
    raising errors on such conflicts.
    
    In the revised text, this is left completely open to implementers, and
    it's more clearly likely and probable that some tools will error in
    these cases. Users are still discouraged from creating this situation,
    regardless of tool behaviors.
    sirosen committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9e8d92e View commit details
    Browse the repository at this point in the history
  5. Add PEP 735 note on direct extras usage

    `uv` presented feedback that they allow for users to directly
    reference content in the `[project]` table, even for non-package
    projects. As a result, the text regarding extras as package metadata,
    and the conflcit this presents with non-package projects, needs
    clarification.
    
    Simply add a section which calls this out explicitly and clarifies.
    sirosen committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    08090a1 View commit details
    Browse the repository at this point in the history
  6. Add use-cases link to the motivation section

    Some of the PEP feedback indicated that readers did not find the link
    to the Use Cases section. Provide a second link in the Motivation
    section, so that it is earlier in the document.
    sirosen committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4cbbc2a View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Remove inaccurate section from 735 about uv

    This text was based on a misunderstanding of information shared in the
    discourse forum. There is no need to keep it.
    sirosen committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4b98785 View commit details
    Browse the repository at this point in the history
  2. Remove mention of requirements.in from 735

    This is extending the PEP text for an ancillary point of confusion --
    there are tool users for `uv` (and possibly `pip-tools`) who do not
    understand that `requirements.in` is a convention that does not
    represent a significantly distinct file-format.
    
    Discussing the difference between these only lengthens the already
    very-long PEP text, and does not add value vis-a-vis community
    standards. Given that neither `requirements.in` nor `requirements.txt`
    have clear specifications, other than "what `pip` accepts", keeping
    with the older and more standardized naming keeps things shorter and
    simpler.
    sirosen committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    608b850 View commit details
    Browse the repository at this point in the history
  3. Refine text around extras for non-packages

    Per suggestion and with additional clarification.
    sirosen committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7388747 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. PEP 735: move project includes to "deferred ideas"

    Move the sections on `[project]` includes and `[build-system]`
    includes to Deferred Ideas, as an added section.
    
    Restore the removed use case for this, as a subsection of one of these
    Deferred Ideas.
    
    Also, per suggestion, remove an unnecessary phrase ("defined below" in
    a context where it is _immediately_ followed by the relevant
    section).
    sirosen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8260b30 View commit details
    Browse the repository at this point in the history