Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 101: Minor updates to major version bump procedure #4003

Merged
merged 2 commits into from
Sep 27, 2024
Merged

PEP 101: Minor updates to major version bump procedure #4003

merged 2 commits into from
Sep 27, 2024

Conversation

zware
Copy link
Member

@zware zware commented Sep 27, 2024 •
edited by github-actions bot
Loading

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--4003.org.readthedocs.build/

@zware zware requested a review from hugovk September 27, 2024 17:34
@zware zware mentioned this pull request Sep 27, 2024
Merged
ned-deily
ned-deily reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggest also opening an issue in python/release-tools to automate this step in release.py.

@zware
Copy link
Member Author

zware commented Sep 27, 2024

I failed to cross-link the other direction; see python/release-tools#170 where @hugovk requested this one :)

hugovk
hugovk approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hugovk hugovk merged commit cb97c7c into python:main Sep 27, 2024
7 checks passed
@zware zware deleted the pep101_add_issue_templates branch September 27, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily left review comments

@Yhg1s Yhg1s Awaiting requested review from Yhg1s Yhg1s is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zware @hugovk @ned-deily