Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 753: Updates #4010

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

PEP 753: Updates #4010

wants to merge 5 commits into from
+76 −33

Conversation

woodruffw
Copy link
Contributor

@woodruffw woodruffw commented Oct 1, 2024 •
edited
Loading

Per https://discuss.python.org/t/pep-753-uniform-project-urls-in-core-metadata/62792/15:

  • Removes the prescription that producers emit normalized labels, and clarifies that normalization should occur during processing on the metadata consumer side.
  • Clarifies that normalized labels are not necessarily unique, per the pre-existing Project-URL spec.
  • Adds an appendix with examples of normalization.
  • Adjusts the proposed living standard location (PyPA specifications instead of PyPI's docs).

CC @pfmoore

Signed-off-by: William Woodruff [email protected]

📚 Documentation preview 📚: https://pep-previews--4010.org.readthedocs.build/

@woodruffw woodruffw requested a review from warsaw as a code owner October 1, 2024 15:58
pfmoore
pfmoore reviewed Oct 1, 2024
View reviewed changes
peps/pep-0753.rst Outdated Show resolved Hide resolved
pfmoore
pfmoore approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor wording clarification, but otherwise LGTM!

@woodruffw @pfmoore
Update peps/pep-0753.rst
4931b81 
Co-authored-by: Paul Moore <[email protected]>
@woodruffw
Copy link
Contributor Author

One minor wording clarification, but otherwise LGTM!

Done, thank you!

willingc
willingc approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the edits.

@woodruffw
Copy link
Contributor Author

woodruffw commented Oct 2, 2024 •
edited
Loading

Thanks! I owe one more based on Alyssa's comment here; I'll have the PR updated in a moment 🙂

Edit: Done!

@woodruffw
PEP 753: remove metadata producer prescriptions
d0c848a 
Label normalization is now entirely prescriptive on the consumer
side.

Signed-off-by: William Woodruff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfmoore pfmoore pfmoore approved these changes

@willingc willingc willingc approved these changes

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woodruffw @pfmoore @willingc