Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 759: External Wheel Hosting #4011

Merged
merged 39 commits into from
Oct 2, 2024
Merged

PEP 759: External Wheel Hosting #4011

merged 39 commits into from
Oct 2, 2024

Conversation

warsaw
Copy link
Member

@warsaw warsaw commented Oct 1, 2024


📚 Documentation preview 📚: https://pep-previews--4011.org.readthedocs.build/

@warsaw warsaw requested a review from a team as a code owner October 1, 2024 20:50
@warsaw warsaw self-assigned this Oct 1, 2024
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
warsaw and others added 8 commits October 1, 2024 14:16
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Copy link
Contributor

@ethanhs-nv ethanhs-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left suggestions which should fix the linter problems :)

peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An initial pass (I haven't looked at Rationale or Specification in depth)

peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Show resolved Hide resolved
peps/pep-0759.rst Show resolved Hide resolved
peps/pep-0759.rst Show resolved Hide resolved
peps/pep-0759.rst Show resolved Hide resolved
@hugovk hugovk changed the title PEP 759, External Wheel Hosting PEP 759: External Wheel Hosting Oct 1, 2024
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions to improve readability for those who have not followed the discussion in forming this PEP. Thanks @warsaw.

peps/pep-0759.rst Outdated Show resolved Hide resolved
peps/pep-0759.rst Outdated Show resolved Hide resolved
warsaw and others added 6 commits October 2, 2024 11:33
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Ethan Smith <[email protected]>
Co-authored-by: Ethan Smith <[email protected]>
Co-authored-by: Ethan Smith <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
warsaw and others added 8 commits October 2, 2024 11:36
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Ethan Smith <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
.github/CODEOWNERS Outdated Show resolved Hide resolved
@warsaw
Copy link
Member Author

warsaw commented Oct 2, 2024

Thank you all for the great feedback. I believe I've addressed all the comments and hopefully the PEP is clearer and more readable now.

@warsaw warsaw enabled auto-merge (squash) October 2, 2024 23:52
@warsaw warsaw merged commit 1490ed1 into python:main Oct 2, 2024
6 checks passed
@warsaw warsaw deleted the warsaw/pep-759 branch October 2, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants