Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: noble support #367

Closed
wants to merge 9 commits into from
Closed

feat: noble support #367

wants to merge 9 commits into from

Conversation

JacobCoffee
Copy link
Member

@JacobCoffee JacobCoffee commented Jul 8, 2024

What

Support for Ubuntu 24.04: Noble

Salt

Highstate succeeds on all but the 2.7 ones (expected):

Succeeded: 201 (changed=2)
Failed:      0
--------------
Total states run:     201
Total run time:    21.804 s
moin.vagrant.psf.io:
    Minion did not return. [Not connected]
hg.vagrant.psf.io:
    Minion did not return. [Not connected]
bugs.vagrant.psf.io:
    Minion did not return. [Not connected]
ERROR: Minions returned with non-zero exit code

@JacobCoffee

This comment was marked as resolved.

@JacobCoffee

This comment was marked as resolved.

@JacobCoffee

This comment was marked as resolved.

@JacobCoffee
Copy link
Member Author

JacobCoffee commented Jul 8, 2024

cdn-logs

==> cdn-logs: Running provisioner: shell...
cdn-logs: Running: inline script
cdn-logs: local:
cdn-logs:     Data failed to compile:
cdn-logs: ----------
cdn-logs:     Pillar failed to render with the following messages:
cdn-logs: ----------
cdn-logs:     Rendering SLS 'firewall.fastly-logging' failed. Please see master log for details.
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

saltstack/salt#66330

@JacobCoffee
Copy link
Member Author

bugs

Fails on one part so far: Python 2.7 packages not being available.
24.04 removes these from the repo.

@JacobCoffee

This comment was marked as resolved.

@JacobCoffee

This comment was marked as resolved.

@JacobCoffee

This comment was marked as resolved.

@JacobCoffee

This comment was marked as resolved.

@JacobCoffee

This comment was marked as resolved.

@JacobCoffee

This comment was marked as resolved.

@JacobCoffee

This comment was marked as resolved.

@JacobCoffee
Copy link
Member Author

moin

2.7 blocker

moin:                   - Running as unit: run-rff0458963d8848179667e42587421b60.
moin:                     E: Package 'python-docutils' has no installation candid
moin:                     E: Unable to locate package python-gdchart2
moin:                     E: Unable to locate package python-xapian
moin:                     E: Unable to locate package python2.7
moin:                     E: Couldn't find any package by glob 'python2.7'
moin:                     E: Couldn't find any package by regex 'python2.7'
moin:                     E: Unable to locate package python2.7-dev
moin:                     E: Couldn't find any package by glob 'python2.7-dev'
moin:                     E: Couldn't find any package by regex 'python2.7-dev'
moin:      Started: 19:47:30.412588
moin:     Duration: 719.63 ms
moin:      Changes:
moin:
moin: Summary for local
moin: --------------
moin: Succeeded: 138 (changed=91)
moin: Failed:      1

@JacobCoffee

This comment was marked as resolved.

@JacobCoffee

This comment was marked as resolved.

@JacobCoffee JacobCoffee marked this pull request as ready for review July 9, 2024 21:06
@JacobCoffee JacobCoffee changed the base branch from main to noble July 9, 2024 21:07
@@ -49,6 +49,16 @@ buildbot-user:
- user: buildbot-user
- file: /srv

{# vagrant up fails due to this file not existing (see: https://github.com/python/psf-salt/pull/367#issuecomment-2218636563) #}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure this is the right move, but it fixed the provisioner

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notably, when I brought this up on the default, focal, it gave the same error... So I'm more inclined to just leave this. I've not yet dug into what eventually touches this in https://github.com/python/buildmaster-config, but this shouldnt hurt much?

@@ -15,5 +15,5 @@ logourl = https://hg.python.org
pygments_style = default
style = hgpythonorg

[extensions]
hgext.highlight =
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to understand the impact of this - it prevented service loading for hg because of pygments package issue.. that may not be a big deal since this is a most old reference?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if adding python3-pygments to the

hg-deps:
would allow it to be restored.

@@ -65,7 +65,6 @@ defaults
balance roundrobin

timeout connect 5000
timeout client 50000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this removed because it is no longer supported in this haproxy version?

Copy link
Member Author

@JacobCoffee JacobCoffee Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will investigate within haproxy/lb PR, weekend brain is strong on a monday :)

@JacobCoffee
Copy link
Member Author

I'll be cherrypicking from this and #365 as I do smaller per-service PRs and one base layer PR for noble support that is ancillary to all services

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants