Add PyLong Import/Export API #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
force-pushed
the
long_import-export
branch
from
7b4d50e to
b521c29
Compare
PyPy is not supported, as well as Py2. In the later case it's possible, but hardly worth code complications: most real-word potential consumers (e.g. Sage, gmpy2 or python-flint) support only Python 3.
skirpichev
force-pushed
the
long_import-export
branch
from
b521c29 to
2337b1f
Compare
|
python/cpython#121339 was merged. What's the status of this PR? Is it up to date and ready to be reviewed? |
vstinner
reviewed
Dec 13, 2024
Co-authored-by: Victor Stinner <[email protected]>
skirpichev
commented
Dec 13, 2024
There was a problem hiding this comment.
Is it up to date and ready to be reviewed?
It's now slightly outdated. PyLongWriter_Create() should reject ndigits==0; export_long should be set to 0 on errors. I'll address this today.
(Unfortunately, I still don't know how implement this for PyPy (not in RPython, but within this project).)
skirpichev
commented
Dec 13, 2024
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyPy is not supported, as well as Py2. In the later case it's possible, but hardly worth code complications: most real-word potential consumers (e.g. Sage, gmpy2 or python-flint) support only Python 3.