Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2102): Add archive sponsorship email templates option #2218

Conversation

augdiebold
Copy link

Related ISSUE: #2102

Description

Create a possibility to archive old email templates that won't be useful anymore instead deleting them.

  • Created a boolean field named 'active' on BaseEmailTemplate model, default=True.
  • Added an active filter filter on django sponsor email templates admin page. Default lookup set to "yes".
  • Created an admin action to archive multiple templates (set them all active=False)

Screenshots

image
image
image

…templates admin, created action to archive multiple templates
@augdiebold augdiebold changed the title https://github.com/python/pythondotorg/issues/2102Add active field to EmailTemplates, create is active filter on email … #2102 - Add archive sponsorship email templates option Dec 29, 2022
@JacobCoffee JacobCoffee changed the title #2102 - Add archive sponsorship email templates option feat(#2102): Add archive sponsorship email templates option Sep 12, 2024
Copy link
Member

@JacobCoffee JacobCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is old, sorry about that, but the migrations have advanced quite a bit since this was made (up to #103 now).

This will need to be rebased on the latest main and then the local migration re-ran.

@JacobCoffee
Copy link
Member

JacobCoffee commented Sep 12, 2024

I understand it has been some time, so I'm going to close this for now. However, this is still wanted/needed I imagine so feel free to open it right back up if you still have the desire to contribute and rebase it on main

With an updated PR, I will 100% review it and get it merged in if it's ready.

@augdiebold
Copy link
Author

No problem @JacobCoffee , thanks for your response I'll rebase and solve it again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants