Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Hugo van Kemenade <[email protected]>
  • Loading branch information
sethmlarson and hugovk authored Sep 3, 2024
1 parent acfe3d2 commit 7b7462c
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions add_to_pydotorg.py
Original file line number Diff line number Diff line change
Expand Up @@ -344,13 +344,16 @@ def has_sigstore_signature(filename: str) -> bool:
)
if not sigstore_version_match:
error(

Check warning on line 346 in add_to_pydotorg.py

View check run for this annotation

Codecov / codecov/patch

add_to_pydotorg.py#L345-L346

Added lines #L345 - L346 were not covered by tests
f"Couldn't determine version of Sigstore CLI: {sigstore_version_stdout.decode()}"
f"Couldn't determine version of Sigstore CLI: "
f"{sigstore_version_stdout.decode()}"
)
sigstore_version = sigstore_version_match.group(1)
sigstore_major_version = int(sigstore_version.partition(".")[0])
if sigstore_major_version < 3:
error(

Check warning on line 353 in add_to_pydotorg.py

View check run for this annotation

Codecov / codecov/patch

add_to_pydotorg.py#L350-L353

Added lines #L350 - L353 were not covered by tests
f"Sigstore v3 or later must be installed (currently {sigstore_version}), run python -m pip install -r requirements.txt"
f"Sigstore v3 or later must be installed "
f"(currently {sigstore_version}), "
f"run: python -m pip install -r requirements.txt"
)
except subprocess.CalledProcessError:
error("Couldn't determine version of Sigstore CLI")
Expand Down

0 comments on commit 7b7462c

Please sign in to comment.