Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and type hints for add_to_pydotorg #146

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 22, 2024

Plus rename with underscores to make testable, and remove some unused functions.

Helps #114.

TODO: After merge, rename as add_to_pydotorg.py in PEP 101.

Copy link
Collaborator

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Hugo! 🚀

@sethmlarson sethmlarson merged commit b20b97d into python:master Jul 23, 2024
9 checks passed
@hugovk hugovk deleted the test-add-to-pydotorg branch July 24, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants