Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add os.EX_OK for Python 3.11 #10748

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Add os.EX_OK for Python 3.11 #10748

merged 4 commits into from
Sep 22, 2023

Conversation

aminalaee
Copy link
Contributor

closes #10242

AlexWaygood
AlexWaygood approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aminalaee
Copy link
Contributor Author

@AlexWaygood Sorry I force-pushed to the branch, can you check it again?

@AlexWaygood
Copy link
Member

AlexWaygood commented Sep 22, 2023 •
edited
Loading

@AlexWaygood Sorry I force-pushed to the branch, can you check it again?

You partially undid the fix I had applied, but I've re-applied it :-)

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 6dfa285 into python:main Sep 22, 2023
66 checks passed
AlexWaygood
AlexWaygood reviewed Sep 22, 2023
View reviewed changes
tests/stubtest_allowlists/win32-py312.txt
Comment on lines 8 to 10
os.get_blocking
os.listdrives
os.listmounts
Copy link
Member

@AlexWaygood AlexWaygood Sep 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bunch of functions were added to the os module on Windows in Python 3.12, that we haven't added yet in typeshed. If you fancy tackling that in a followup PR, it would be really valuable!

Much like os.EX_OK, it looks like at least some of them already existed on other platforms:

typeshed/stdlib/os/__init__.pyi

Line 624 in 6dfa285

def get_blocking(__fd: int) -> bool: ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sure, I'd love to.

@aminalaee aminalaee deleted the add-os-ex-ok-windows branch September 22, 2023 11:54
This was referenced Sep 22, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

os.EX_OK exists on Win32
2 participants
@aminalaee @AlexWaygood