Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix str2bool failure on stubsabot dry-run #12287

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Fix str2bool failure on stubsabot dry-run #12287

merged 2 commits into from
Jul 6, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 6, 2024

Let's test this :)

Closes #12272

@sobolevn
Copy link
Member Author

sobolevn commented Jul 6, 2024

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would love @hauntsaninja to take a look!

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, didn't realise sdists could be zip. Thanks for testing sobolevn!

@hauntsaninja hauntsaninja merged commit 7c26da2 into main Jul 6, 2024
6 checks passed
@hauntsaninja hauntsaninja deleted the issue-12272 branch July 6, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

str2bool package causes assertion failures during stubsabot runs
4 participants