Enforce positional args for codec functions
#12343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-muoto
changed the title
code functionscodec functions
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
max-muoto
commented
Jul 14, 2024
| @@ -209,3 +203,11 @@ typing.SupportsAbs.__type_params__ | |||
| typing.SupportsRound.__type_params__ | |||
| typing_extensions.SupportsAbs.__type_params__ | |||
| typing_extensions.SupportsRound.__type_params__ | |||
|
|
|||
| # Runtime incorrectly has `self` | |||
There was a problem hiding this comment.
srittau
approved these changes
Jul 15, 2024
max-muoto
added a commit
to max-muoto/typeshed
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly enforce positional arguments for
codecfunctions, this applies to 3.13, and earlier versions.