Skip to content

Fix typing of Pickler.persistent_id and Unpickler.persistent_load for Python < 3.13. #13818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 12, 2025
Merged

Fix typing of Pickler.persistent_id and Unpickler.persistent_load for Python < 3.13. #13818

merged 4 commits into from
Apr 12, 2025

Conversation

Holt59
Copy link
Contributor

@Holt59 Holt59 commented Apr 11, 2025

Fixes #13817

I am not sure if the usage of Self here is allowed or requires some kind of version checking, let me know if that's the case.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@Holt59
Copy link
Contributor Author

Holt59 commented Apr 12, 2025 •
edited
Loading

@srittau I changed the PR according to your comment #13817 (comment), but the stubtests now fail. Should I roll-back to the original version of this PR?

@srittau
Copy link
Collaborator

srittau commented Apr 12, 2025

@Holt59 Just adding

# These methods have no default implementation for Python < 3.13.
_pickle.Pickler.persistent_id
_pickle.Unpickler.persistent_load
pickle.Pickler.persistent_id
pickle.Unpickler.persistent_load

to each of stdlib/@tests/stubtest_allowlists/py*.txt (except py313.txt) should work around this.

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 7ffb7e0 into python:main Apr 12, 2025
55 checks passed
mmingyu pushed a commit to mmingyu/typeshed that referenced this pull request May 16, 2025
@Holt59
Fix typing of Pickler.persistent_id and Unpickler.persistent_load for…
e68c80e 
… Python < 3.13. (python#13818)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid typing for Pickler.persistent_id and Unpickler.persistent_load?

2 participants

@Holt59 @srittau