Skip to content

Commit

Permalink
Merge branch 'overloads' of https://github.com/erictraut/typing into …
Browse files Browse the repository at this point in the history
…overloads

* 'overloads' of https://github.com/erictraut/typing:
  [pre-commit.ci] auto fixes from pre-commit.com hooks
  • Loading branch information
erictraut committed Aug 16, 2024
2 parents 660295c + f993b28 commit 06c86f1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions docs/spec/overload.rst
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ programming error and should be reported by type checkers::
@overload
def func1(x: int) -> str: ...

[Eric's note for reviewers: Mypy exempts `__get__` from the above check.
[Eric's note for reviewers: Mypy exempts `__get__` from the above check.
Refer to https://github.com/python/typing/issues/253#issuecomment-389262904
for Ivan's explanation. I'm not convinced this exemption is necessary.
Currently pyright copies the exemption. Do we want to codify this or leave it
Expand Down Expand Up @@ -503,4 +503,3 @@ For example, if class C inherits from A and B, should we expand C into A and B
for purposes of overload matching? This could get very expensive and difficult
to spec, and it feels like a significant edge case, so I'm inclined to leave it
out. No one has asked for this, to my knowledge.]

0 comments on commit 06c86f1

Please sign in to comment.